Skip to content

Add instrumentation support to the typescript code #12991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Feb 26, 2025
Merged

Add instrumentation support to the typescript code #12991

merged 31 commits into from
Feb 26, 2025

Conversation

@fearthecowboy
Copy link
Contributor

This adds the instrumentation support to enable performance testing and monitoring.

It:

  • cleaned up some calls to logging so that we're not over-importing in typescript
  • patches the logging so that log messages are sent to the collector.
  • adds calls to monkey-patch vscode, the client and the providers so that we get monitoring events for as much as possible.
  • if the PERFECTO_LAUNCH_SETTINGS environment variable is not set, everything here is a no-op
  • the actual instrumentation code is loaded by the perfecto tool

@fearthecowboy fearthecowboy requested a review from a team as a code owner November 22, 2024 21:30
bobbrow
bobbrow reviewed Dec 5, 2024
View reviewed changes
fearthecowboy and others added 16 commits January 3, 2025 10:32
@fearthecowboy
work around webpack
53dd899
@fearthecowboy
webpack! Arg!
c5d8af4
@fearthecowboy
Merge branch 'main' of https://github.com/microsoft/vscode-cpptools i…
35172cb 
…nto dev/garretts/instrumentation
@fearthecowboy
cleanup
fbb07e6
@fearthecowboy
cleanups
d272d97
@fearthecowboy
remove spaces
9a22dc2
@fearthecowboy
must use eval to work around webpack
b147b2b
@fearthecowboy
Merge branch 'main' of https://github.com/microsoft/vscode-cpptools i…
86c26c1 
…nto dev/garretts/instrumentation
@fearthecowboy
need vscode in here
2b87424
@fearthecowboy
Merge branch 'main' of https://github.com/microsoft/vscode-cpptools i…
9270034 
…nto dev/garretts/instrumentation
@fearthecowboy
Merge branch 'main' of https://github.com/microsoft/vscode-cpptools i…
30044a4 
…nto dev/garretts/instrumentation
@fearthecowboy
fix line endings?
b016317
@fearthecowboy
fix line endings?
4c206b2
@fearthecowboy
Add comment
d71e4fb
@fearthecowboy
Merge branch 'main' of https://github.com/microsoft/vscode-cpptools i…
9d09405 
…nto dev/garretts/instrumentation
@fearthecowboy
Merge branch 'dev/garretts/instrumentation' of https://github.com/mic…
0a2c368 
…rosoft/vscode-cpptools into dev/garretts/instrumentation
sean-mcmanus
sean-mcmanus reviewed Feb 14, 2025
View reviewed changes
sean-mcmanus
sean-mcmanus reviewed Feb 14, 2025
View reviewed changes
sean-mcmanus
sean-mcmanus requested changes Feb 26, 2025
View reviewed changes
sean-mcmanus
sean-mcmanus reviewed Feb 26, 2025
View reviewed changes
sean-mcmanus
sean-mcmanus requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the instrument be added for vscode.languages.registerCodeActionsProvider in extension.ts?

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Feb 26, 2025 •
edited
Loading

FYI, a copilotCompletionProvider got added recently, but I don't know how you would handle that with instrument.

Maybe here?

            this.contextProviderDisposable = contextAPI.registerContextProvider({
                id: CopilotCompletionContextProvider.providerId,
                selector: CopilotCompletionContextProvider.defaultCppDocumentSelector,
                resolver: this
            });

@fearthecowboy fearthecowboy merged commit a2b7383 into main Feb 26, 2025
6 checks passed
@fearthecowboy fearthecowboy deleted the dev/garretts/instrumentation branch February 26, 2025 22:28
@github-project-automation github-project-automation bot moved this from Pull Request to Done in cpptools Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobbrow bobbrow bobbrow left review comments

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

cpptools
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fearthecowboy @sean-mcmanus @bobbrow